[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warnings

> 
> Hi Julian,
> 
> > Here are some diffs to get rid of some warnings:
> 
> > 761c761
> > < 	if (( r = (*fc.fs->getxattr)(&fc, &xattr) < 0 ))
> > ---
> > > 	if (0 != ( r = (*fc.fs->getxattr)(&fc, &xattr) < 0 ))
> 
> it seems that Pure C had a good reason to issue this warning: I guess that
> the line should have been:
> 
> 	if ((r = (*fc.fs->getxattr)(&fc, &xattr)) < 0)
> 
> which is not the same, since the assigment operator has lower
> precedence than the comparison operator.
> 
> Thierry.
> 

Indeed!

BTW: sorry for sending non-context diffs; I'll do it better next week...