[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] stdio write problem in mintlib



Alan Hourihane a écrit :
Can people review ?

I see with this patch, a stream turns into binmode if it is not S_ISCHR() (character device : tty, serial...)
I think it would be better to use binmode when not S_ISREG() (regular file).
Maybe it would be better to use binmode by default, and switch to textmode only if S_ISREG() and UNIXMODE != b.

Special care must be taken with the console. I think it should remain in binmode (to be verified), but with special handling to display (and input) everything as expected. With MiNT and TOS.

Well, we have to be very careful to avoid regessions...

--
Vincent Rivière