[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [MiNT] FreeMiNT CVS kernel patch
Alan Hourihane wrote :
> Here's a patch against the current CVS to allow FreeMiNT to build with
> GCC 4.
I've just quickly looked at the patch.
The changes in mfp.c smells bad...
You replaced the assembly labels mfp1_dcdint and friends by real
functions, which contains an extra prologue/epilogue.
What was the original problem ?
Note: For interrupt handlers, it may be preferable to use attribute
((signal)) and/or attribute ((naked)), like in the example here:
http://www.freertos.org/implementation/a00013.html
However, I'm pretty sure that mfp.c could be compilable without such
fundamental changes.
--
Vincent Rivière