Re: [MiNT] cflib/gemlib/gemma trap sanitizer

[Alan Hourihane <alanh@fairlite.co.uk>]

On Sat, 2009-12-19 at 18:28 +0100, Vincent Rivière wrote:
> Here is my patch to fix the potential problems with trashed registers on 
> trap calls in the lib directory (cflib/gemlib/gemma).
> 
> For gemlib and cflib, I added d1/d2/a2 to the list of potential trashed 
> registers. I don't know if it will fix something, but it can't harm, and it 
> seems to be the official way to do.
> 
> In gemma, the clobber list was clearly wrong, so programs using it may be 
> fixed with this patch.
> 
> I have tested this patch very few due to lack of test programs, but it 
> compiles well, and I really believe it is correct.
> 
> Dear maintainers, please commit this patch.
> 
> Beware: the file gemlib/_lc_asm.s has CR/LF line endings, they may be 
> removed by sending the patch on the list.
> 
> Please use the following CVS description:
> --------------------
> Always assume that d0-d2/a0-a2 can be modified on trap calls.
> Replaced some assembler instructions by faster ones.
> --------------------
> 
> Note: ColdFire support in included only for GemLib, as I have not ported the 
> other libs yet.

Vincent,

Can you take another look at this patch as it doesn't apply cleanly to
CVS....

patching file cflib/nkcc-gc.s
patching file cflib/nkcc-pc.s
patching file gemlib/_gc_asm_aes.S
patching file gemlib/_gc_asm_vdi.S
patching file gemlib/_gc_asm_vq_gdos.S
patching file gemlib/_gc_asm_vq_vgdos.S
patching file gemlib/_lc_asm.s
Hunk #1 FAILED at 15.
1 out of 1 hunk FAILED -- saving rejects to file gemlib/_lc_asm.s.rej
patching file gemlib/_pc_asm.s
patching file gemlib/_sx_asm.s
patching file gemlib/gem_aesP.h
patching file gemlib/gem_vdiP.h
patching file gemma/src/gemproto.h

Thanks,

Alan.