[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[MiNT] Possible bug in cflib's font selector



Hello.

I have closed this bug because it has been fixed:
http://sparemint.org/bugtracker/view.php?id=158

But I looked at the file cflib/fontsel.c and I found a very bad smell in the clobber lists (once again):
http://www.atariforge.net/cgi-bin/cvsweb/lib/cflib/fontsel.c?rev=1.5&content-type=text/x-cvsweb-markup

I guess the functions xfsl_init(), xfsl_event() and xfsl_exit() are called via assembler functions to cope with the mshort API, right ?

I found some documentation here:
http://toshyp.atari.org/00d00e.htm#Pure-C_20and_20_27cdecl_27
It says that the API is "Pure C cdecl".
Does this mean that the clobbered registers are d0/d1/a0/a1, like GCC ? Do you agree, Henk ?

It this is right, d2 should not be present in the clobber lists, and a1 is missing. Even worse for xfsl_exit().

Am I right ?

--
Vincent Rivière