[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] Patch: Deadkey support

On Sun, 2009-12-20 at 21:31 +0100, Jo Even Skarstein wrote:
> Ok, this is the first time I submit any kind of patches to this list, so 
>   maintainers - please bear with me ;-)
> First of all, I'm not sure how well tested things must be before 
> submitted. I have been using this for about a week with no problems. It 
> works when no keyboard tables are loaded, when keyboard tables with no 
> deadkeys are loaded and when tables with deadkeys are loaded.
> Also, I'm still not sure about how my coding style fits, but I tried to 
> adapt to the style used by Draco and Ozk.
> And finally, I know almost nothing about diff. I used the guide Vincent 
> posted about a week ago, but I see that there are some absolute paths in 
> the patch that perhaps shouldn't be there.
> CVS entry:
> Added support for deadkeys. Two keystrokes can be combined to produce an 
> accented character, depending on the loaded keyboard table. The keyboard 
> table file format is extended with a NULL-terminated 'deadkey'-table. 
> This extended table can still be built with mktbl.

Committed. Thanks.