[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] Missing parenthesis in mint/sysvars.h



Le Fri, 09 Apr 2010 23:30:25 +0200
Vincent Rivière <vincent.riviere@freesbee.fr> a écrit:

> Patrice Mandin wrote:
> > There is a missing ( for the definition of vblsem, in mint/sysvars.h:
> > #define vblsem		((short *) 0x452L))  /* vbl semaphore */
> >
> > It should be:
> > #define vblsem		(((short *) 0x452L))  /* vbl semaphore */
> 
> Or better, the last closing one should be removed.

I simply propose fixing the way other values are #defined in this file,
because it breaks compilation of software using vblsem (currently
radeon driver for ctpci).

I suppose there was a reason to do:
#define value (( (type) address ))
instead of
#define value ( (type) address )

-- 
Patrice Mandin
WWW: http://pmandin.atari.org/
Programmeur Linux, Atari
Spécialité: Développement, jeux