[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] typo in keyboard.c



On Sun, 2010-05-23 at 09:22 +0200, Helmut Karlowski wrote:
> There's a typo in line 160 in keyboard.c:
> 
> static char makes[MAKES_BLEN + 1 * 2];
> 
> should be:
> 
> static char makes[MAKES_BLEN * 2 + 1];
> 
> or even:
> 
> static char makes[MAKES_BLEN * 2 - 1];
> 
> This may cause severe problems. I recommend not to use kernels with this  
> error.
> 
> There is a good chance that this also causes eiffel-bug.
> 
> I've committed the fix to my branch.

Helmut,

I've pulled in this fix and I agree it could cause some unwanted
behaviour, but where is the makes[] structure actually used ?

It seems to be filled in during ikbd_scan(), but I can't see where
makes[] is actually used anywhere else to make use of that data ?

Alan.