[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] Set of patches for current release



Miro,

Thanks for spending the time on this but the release.patch is wrong.

You've placed all the copying and hardcoding of filenames into the
Makefile, yet these should be split over the entire Makefile process.

For example, copying the ext2.xfs should be done in the ext2 Makefile,
and copying of xif files should be done in their respective Makefiles
etc as only those Makefiles know if things got built and what the names
are.

Can you re-work it ?

Thanks,

Alan.

On Sat, 2010-08-14 at 23:09 +0200, Miro Kropacek wrote:
> Hi,
> 
> with a little delay (I was ill for a few days) here are promised
> patches for making release file structure a little bit user friendly.
> 
> release.patch: main work, placed into Makefile instead of RULES since
> RULES is included into all sub-Makefiles. Adds 'release' and
> 'releaseclean' target
> 
> strip.patch: fixed / added 'strip' targets where needed
> 
> user.patch: minor changes in docs / configuration files
> 
> werror.patch -- current CVS tree is unable to compile with gcc 4.5.1
> 
> It's nothing complex as you can see but I think it makes release work
> easier. Open issues:
> 
> - what about documentation? I have included none yet except READMEs
> for kernel modules.
> 
> - same for tools? 1.16 releases did include tools folder, many XDDs /
> XFSs mention tools they need for their work (audio, nfs, mktbl, ...),
> not to mention some really useful ones like TosWin. Also: what about
> scripts like fsck?
> 
> If you don't have a time to test full build, here is an output:
> 
> auto  mint
> 
> ./auto:
> mint030.prx  mint040.prx  mintara.prx  mintmil.prx  mint.prg
> 
> ./mint:
> 1-17-0  COPYING  COPYING.GPL  COPYING.LGPL  COPYING.MiNT
> 
> ./mint/1-17-0:
> mint.cnf  readme  tbl  xaaes  xdd  xfs  xif
> 
> ./mint/1-17-0/tbl:
> british.tbl    czech_kam.tbl  french.tbl  italian.tbl   pol-chfr.tbl
> pol-fr.tbl  polish.txt  pol-sp.tbl   readme.1st   swiss_de.tbl
> czech_iso.tbl  czech.txt      german.tbl  pol-chde.tbl  pol-de.tbl
> pol-gb.tbl  pol-it.tbl  pol-usa.tbl  spanish.tbl  swiss_fr.tbl
> 
> ./mint/1-17-0/xaaes:
> img        moose.txt    widgets       xaaes030.km  xaaes060.km
> xaaes.km   xaaeswdg.rsc  xa_mono.rsc   xobj
> moose.adi  moose_w.adi  xaaes009.rsc  xaaes040.km  xaaes.cnf
> xaaes.rsc  xaloader.prg  xa_xtobj.rsc
> 
> ./mint/1-17-0/xaaes/img:
> 8b  hc
> 
> ./mint/1-17-0/xaaes/img/8b:
> dbox.img  dbutton.img  dtext.img  exterior.img  info.img  popbkg.img
> slide.img  slider.img  slwtitle.img  wtitle.img
> 
> ./mint/1-17-0/xaaes/img/hc:
> dbox.img  dbutton.img  dtext.img  exterior.img  info.img  popbkg.img
> slide.img  slider.img  wtitle.img
> 
> ./mint/1-17-0/xaaes/widgets:
> adam.rsc      cbox1214.rsc  cboxwidg.rsc  gilwidg.rsc  ligt_wdg.rsc
> mbox1214.rsc  mboxwidg.rsc  nine-ozk.rsc  nine-wdg.rsc  ronb_wdg.rsc
> rond_wdg.rsc  w98_wdg.rsc  xaaeswdg.rsc
> baroqwdg.rsc  cboxwdg.rsc   gemjwdg.rsc   homwdg.rsc   magicwdg.rsc
> mboxwdg.rsc   monowidg.rsc  nine_wdg.rsc  pas_wdg.rsc   rondswdg.rsc
> styl_wdg.rsc  win_wdg.rsc
> 
> ./mint/1-17-0/xaaes/xobj:
> nine-ozk.rsc  simple.rsc  style.rsc
> 
> ./mint/1-17-0/xdd:
> audiodev.txt  dsp56k.txt  flop_raw.txt  inet4.txt  lp.xdd
> mfp.txt  nfstderr.txt  ports.txt  scc.xdd   uart.xdd      xconout2.xdd
> audiodev.xdd  dsp56k.xdd  flop_raw.xdd  inet4.xdd  mfp_mil.xdd
> mfp.xdd  nfstderr.xdd  scc.txt    uart.txt  xconout2.txt
> 
> ./mint/1-17-0/xfs:
> aranym.txt  aranym.xfs  ext2.txt  ext2.xfs  hostfs.txt  hostfs.xfs
> minix.txt  minix.xfs  nfs.txt  nfs.xfs
> 
> ./mint/1-17-0/xif:
> biodma.txt  de600.txt  dial.txt  ethernat.txt  lance.txt  nfeth.txt
> pamsdma.txt  plip.txt  ppp.txt       rblspc_f.xif  rieblmst.xif
> rieblste.xif  rtl8012st.xif  scsilink.txt  slip.txt
> biodma.xif  de600.xif  dial.xif  ethernat.xif  lance.xif  nfeth.xif
> pamsdma.xif  plip.xif  rblmst_f.xif  readme.1st    rieblspc.xif
> riebltt.xif   rtl8012.xif    scsilink.xif  slip.xif
> 
> Btw, someone with write access should definitely remove all those
> empty folders in CVS, it's so annoying to check them everytime and
> then discover there's nothing in them...
>