[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] QED crash when closing the Syntax dialog



on 12/24/10 11:49 AM, Vincent Rivière wrote:

> Hello.
> 
> I have found a bug on my home compiled QED. It crashes when closing the
> Options > Syntax dialog, just after clicking Cancel.
> 
> The bug is in src/options.c, function set_syntax_options().
> When Hl_EnumTxtNames() does not return anything (no text rules),
> create_popup() is not called so txtnames remains uninitialized. When the
> dialog is closed, free_popup() is called with the uninitialized txtnames
> popup then it crashes (tested with EasyMiNT).
> 
> It is "funny" to see it behaves differently on ST. Due to the 24-bit
> address bus, free_popup() loops during 4 seconds on wrong but valid
> addresses, then it succeeds after 4 seconds.
> 
> The attached patch fixes the problem.
> Please commit it with the following CVS comment:
> 
> Fixed crash when closing the Syntax dialog when there are no text rules.

I still have the problem with cut/paste, after heavy use like several hours
it always freezes up. Rather consistent, but I'm using N.Aes.  With light
use it don't happen, it takes a marathon coding session.  I'm using the
build from gokmase's page. I have to kill it twice, then it won't run again
until I reboot.  I figure it has memory leak or runs out of file handles or
something along those lines.

-- 
Lonny Pursell    http://www.bright.net/~gfabasic/