[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [MiNT] Network sockets don't work with new 1.18.current
- To: mint@lists.fishpool.fi
 
- Subject: Re: [MiNT] Network sockets don't work with new 1.18.current
 
- From: David Gálvez <dgalvez75@gmail.com>
 
- Date: Thu, 6 Jan 2011 22:48:49 +0100
 
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=gamma;        h=domainkey-signature:mime-version:received:received:in-reply-to         :references:date:message-id:subject:from:to:content-type         :content-transfer-encoding;        bh=TykZjF6G0z9pCn210XC3SRPxaSALuLk4W/OQ4G3gP3I=;        b=owZ79WKKQhDpqOZfVNXqRRqniJTSQdVPX7ChqO62XiQS0/Y0uFlZAnXVZrbOpAzQAG         /OxQlVP1SsoyhsqOkVq+yxDFW1zqu7ZBu3nZZ5hJxp6haNTiLva5TxjRU2BL9NC2w/Sb         amJr58PwjvYnzzIhyHx5kqaIQbcNp2SO5joLM=
 
- Domainkey-signature: a=rsa-sha1; c=nofws;        d=gmail.com; s=gamma;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :content-type:content-transfer-encoding;        b=uupH4qg8oj2qJseohQB2zFURJIRAKIXRwlxYdIde19v8jsgLcQsjCEx75U4dPS/PFA         0cFls4512sPfONqdGGgQszkBCKt+vZNSbH7wI03l7FXtK/P3Zqf3L9bL8eahhdteO0EJ         8UdHJUNonAYxE9HCyn/bSlgnPhvwZW1mPD6C4=
 
- In-reply-to: <AANLkTikfwR95j=MgGJodvkiHOsw46dWytanFE_M1PBoH@mail.gmail.com>
 
- List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>
 
- List-id: <mint.lists.fishpool.fi>
 
- List-owner: <mailto:tjhukkan@fishpool.fi>
 
- List-post: <mailto:mint@lists.fishpool.fi>
 
- List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>
 
- List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>
 
- References: <AANLkTikfwR95j=MgGJodvkiHOsw46dWytanFE_M1PBoH@mail.gmail.com>
 
- Sender: mint-bounce@lists.fishpool.fi
 
2011/1/6 David Gálvez <dgalvez75@gmail.com>:
> I don't know why the check is done like that, it's very easy to forget
> putting the correct version when the kernel version is bumped.
>
> Wouldn't be better to do something like this?
>
> if ((MINT_MAJOR == 0)
>                || ((MINT_MAJOR == 1) && ((MINT_MINOR < 15) || (MINT_KVERSION < 2)))
> || !so_register)
>
> As is done in other modules, just check that version is newer than
> 1.15 and kerinfo version 2 or upper??
>
Now that I think about this....inet4.xdd is more tight to the kernel
than other modules, then is understandable why the exact minor version
is checked.