[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] NOCFLAGS $(MODEL)



Am 22.03.2011, 00:19 Uhr, schrieb Vincent Rivière <vincent.riviere@freesbee.fr>:

Hello.

Seen in FreeMiNT's files:
sys/Makefiles.objs
sys/arch/Makefiles.objs
sys/libkern/Makefiles.objs

Stuff like:
NOCFLAGS-md5.c = $(MODEL)
CFLAGS-md5.c = -m68000

This has the effect of removing the specific CPU option, and use -m68000 instead. So those files are not optimized for the target CPU :-(

Does this make sense, for C files ?
If some of these files does no compile due to inline assembly, the offending parts should be patched accordingly.

I agree, but at least you know what files need to be patched.

As a test, I have removed all those specific cases for ColdFire and everything works well.

You say they compiled without error? Why have they been added?

I would be tempted to remove that specific stuff for all the CPU variants.

I know I got compiler-errors for some XaAES-files for coldfire and just imitated what was done in the kernel.

Any comments ?

Surely they should be adapted so in the end this NOFLAGS-stuff can go away.

--
Helmut Karlowski