[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[MiNT] Keyclick fixes



Helmut Karlowski wrote:
After someone commits my first patch for the kernel to avoid keyclicks
on real wheel actions, I will provide another one to generate the
keyclicks on appropriate keyboard actions, such as Shift+F6.

Just comitted.

Here is an intermediate patch. Since the standard keyclick routine ignores the scancode passed as parameter, no one noticed that it was wrong.

Helmut, please commit!

Fixed the scancode passed to the key click routine. Contributed by Vincent Riviere.

--
Vincent Rivière
diff -x CVS -aurN freemint.orig/sys/arch/intr.S freemint/sys/arch/intr.S
--- freemint.orig/sys/arch/intr.S	2010-01-15 20:44:35.218750000 +0100
+++ freemint/sys/arch/intr.S	2011-05-21 12:15:23.781250000 +0200
@@ -419,7 +419,7 @@
 	beq.s	L_pop
 	move.l	d0,a0
 	clr.l	d0
-	move.w	28(sp),d0	// scancode
+	move.w	64(sp),d0	// scancode
 	jsr	(a0)
 L_pop:	movem.l	(sp)+,d0-a6
 L_nocl:	rts
diff -x CVS -aurN freemint.orig/sys/keyboard.c freemint/sys/keyboard.c
--- freemint.orig/sys/keyboard.c	2011-05-21 00:37:10.125000000 +0200
+++ freemint/sys/keyboard.c	2011-05-21 12:49:05.984375000 +0200
@@ -609,7 +609,7 @@
 		last_key[3] = c3;
 
 		if (!is_eiffel_mouse_key(c1))
-			kbdclick((ushort)c2);
+			kbdclick(c1);
 	}
 
 	kintr = 1;