[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.

To: <mint@lists.fishpool.fi>
Subject: Re: [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.
From: m0n0 <ole@monochrom.net>
Date: Fri, 25 Nov 2011 14:51:48 +0100
In-reply-to: <f163fbf21016c010cd32ea3b7fd57662-EhVcX1lFRQVaRwYcDTpQCEFddQZLVF5dQUNBAjBeX15ZVF0WXFdoAFdRMl5cQ0QKXFtfSF8=-webmailer2@server05.webmailer.hosteurope.de>
List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>
List-id: <mint.lists.fishpool.fi>
List-owner: <mailto:tjhukkan@fishpool.fi>
List-post: <mailto:mint@lists.fishpool.fi>
List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>
List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>
References: <84700916294697e91967521b2a0cd28d-EhVcX1lFRQVaRwYcDTpQCEFddQZLVF5dQUNBAjBeX15ZVF0WXVtoAFJWMl5cQ0QKXlteQVA=-webmailer2@server03.webmailer.hosteurope.de> <1321817862.16157.44.camel@schizonils> <4EC98592.1030602@freesbee.fr> <f163fbf21016c010cd32ea3b7fd57662-EhVcX1lFRQVaRwYcDTpQCEFddQZLVF5dQUNBAjBeX15ZVF0WXFdoAFdRMl5cQ0QKXFtfSF8=-webmailer2@server05.webmailer.hosteurope.de>
Reply-to: ole@monochrom.net
Sender: mint-bounce@lists.fishpool.fi
User-agent: Host Europe Webmailer/2.0


Hello,

No, this is not enough:

fec.c: In function 'fec_config':
fec.c:1390:16: error: variable 'cp' set but not used
[-Werror=unused-but-set-variable]
fec.c:1402:16: error: variable 'cp' set but not used
[-Werror=unused-but-set-variable]


Thanks,

I attached a patch which should fix that. The attached patch assumes
the first one that I posted isn't committed.


Alan, did you recognize my patch? Just wanted to ask.

Greets,
m

References:
- [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.
  - From: m0n0 <ole@monochrom.net>
- Re: [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.
  - From: Jo Even Skarstein <joska@online.no>
- Re: [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.
  - From: Vincent Rivière <vincent.riviere@freesbee.fr>
- Re: [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.
  - From: m0n0 <ole@monochrom.net>

Prev by Date: [MiNT] [PATCH]Define DEV_DEBUG in USBDEFS
Next by Date: [MiNT] [PATCH]Making the USB module loader to load the right km
Previous by thread: Re: [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.
Next by thread: Re: [MiNT] Patch fec.xif: Read FireTOS params via correct interface, drop assigned but unused variables.
Index(es):
- Date
- Thread