Re: [MiNT] Patch: shel_write() did not call the PureC patcher

["Helmut Karlowski" <helmut.karlowski@ish.de>]

Eero Tamminen wrote:

> Yes, the function name is also bad, it should reflect the fact
> that it's ColdFire only.   It could be renamed to something like
> coldfire_patch_memset_purec (or something shorter, but still
> understandable).
>
> The header name should also reflect the fact that it contains
> ColdFire only functionality.

That's what it says it does, and you can believe it or not ..

> If you have only few ifdefs and they don't nest, this doesn't
> matter so much, but with large number of conditional build
> options, they start to have serious impact on readability.

It' not a big issue in MiNT, more in XaAES, but still readable.

I've seen much worse #if-nestings and these are not easy to understand indeed.

> Instead of define, one could also use empty static function,
> like mentioned here:
> 	http://www.linuxjournal.com/article/5780?page=0,3

Too much complication ;)

-Helmut