Re: [MiNT] [PATCH] Disable memory protection if the PMMU is not present

[Vincent Rivière <vincent.riviere@freesbee.fr>]

On 10/01/2013 23:17, Miro Kropáček wrote:
> today I managed to crash my MMU on Aranym for 1000th time so here I am, with
> a patch fixing it.

Good initiative.

> - cleans up some unused code and activates real 040 instructions instead of
> dc.w (we've got assemblers mature enough for years)

We should just ensure that it works with the official gas for MiNT (whatever 
version it is).

Usually, I prefer to use the right assembler mnemonics, as you did, because 
the code is written for a specific processor, and the assembler is supposed 
to do the right thing with those mnemonics.

The only exception is instructions to auto-detect CPU/FPU/FPU features. Some 
instructions may be tried on any processor, then the Illegal Instruction 
exception can be used to see if the feature is present or not. In such case, 
it is worth to use dc.w, because the detection code can be compiled on every 
target

> - fixes the boot menu -- current code has several bugs ('6' doesn't work,

I removed the '5' menu entry on targets lacking MMU support (68000, 
ColdFire...). I hope that I didn't break the '6' with my changes :-\

> yes/no are cycled in 3 key strokes,

Really, I never saw that, with both ARAnyM and the FireBee.
Are you sure that you didn't hit that damn initial key repeat bug? You 
should use the latest EmuTOS snapshot on ARAnyM to avoid that. However, I'm 
pretty sure that FreeMiNT only hacks the ikbdvecs *after* the boot menu, so 
I'm not sure if my remark makes sense.

--
Vincent Rivière