[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] FreeMiNT 1.18 release



On 01/25/13 21:32, Vincent Rivière wrote:
On 25/01/2013 21:36, Helmut Karlowski wrote:
1. sleep 2 &
2. exit

I do not type exit, only the first line and wait 2 seconds (sleep 1 should
do also).

I also reproduce the bug.


What actually are you seeing ?

Up to date FreeMiNT and XaAES from the daily trunk archive, and the 68000 TosWin2 from there: http://vincent.riviere.free.fr/soft/m68k-atari-mint/archives/mint/toswin2/


Why this specific version of toswin2, what's wrong with the one in the trunk code ?

I can also reproduce the bug with QED:

/c/qed/qed.app &

When I do "File > Quit" in QED, TosWin2 also exits.


I'll try with QED.

Alternatively, the only thing I can think of is that toswin2 isn't dealing with interrupted select calls correctly.

Can someone who is experiencing this problem try this patch ?

Alan.
Index: proc.c
===================================================================
RCS file: /mint/freemint/tools/toswin2/proc.c,v
retrieving revision 1.11
diff -u -r1.11 proc.c
--- proc.c	22 Jan 2008 13:42:46 -0000	1.11
+++ proc.c	25 Jan 2013 18:39:39 -0000
@@ -403,6 +403,7 @@
 
 	if (fdmask) 
 	{
+again:
 		readfds = fdmask;
 		if ((r = Fselect(1, &readfds, 0L, 0L)) > 0) 
 		{
@@ -429,6 +430,11 @@
 				}
 			}
 		}
+
+		/* Select was interrupted, try again. */
+		if (r == -EINTR)
+			goto again;
+
 		if (checkdead)
 			rebuild_fdmask(checkdead);
 	}