Re: [MiNT] tw-call.app bug when toswin2.app is missing

["Helmut Karlowski" <helmut.karlowski@ish.de>]

Vincent Rivière, 09.01.2013 22:17:23:

> Hello.
>
> It seems that there is a bug in tw-call.app when toswin2.app is not  
> found.
> Look there, at the end of the find_tw() function:
> http://sparemint.atariforge.net/cgi-bin/cvsweb/freemint/tools/toswin2/tw-call/tw-call.c?rev=1.7&content-type=text/x-cvsweb-markup
>
> The code calls shel_write(1, 1, 1, ...) to run toswin2.app, then it  
> assumes that the return value is the app_id. However, it seems that when  
> toswin2.app is missing, the returned value is also non-null. Then things  
> goes wrong.

This is another XaAES-bug:

launch() should return <0 on error, but it returns a positive error-num  
instead that cannot be distinguished from a pid. shel_write should return  
0 on error.

http://toshyp.atari.org/en/008012.html#shel_write

Return value:	 An error has arisen only if the value 0 is returned.

Has to be fixed.

> Also, is that evnt_timer(500L) really useful?
>
> Could some AES guru look at that code, please?

Ha - ha - Guess I need my meditation now. Ask again next week :)

What's wrong with that? I don't think it's AES-related - it just wants to  
wait until the launched app is initialized and running, don't know why.

--
Helmut Karlowski