[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH] Firebee software poweroff



On Sun, 2013-12-15 at 21:53 +0100, Vincent Rivière wrote:

> I have slightly improved Jo Even's patch.

Thank you for fixing my crude hack. Basically I just stole a couple of
lines of code and some #define's from BaS. But I'm wondering about the
TXRDY register. I left that test out on purpose simply because in BaS
this test always returns true. So I simplified it, but maybe I should
have fixed BaS instead... (BaS-gcc, BaS.c, lines 64-69).

> It is really good news that communicating with the PIC is so easy from 
> FreeMiNT. It means that when new features are added to the PIC (battery 
> monitor, etc.), they will be easily available in the kernel.

I am looking into PIC code now, the goal is to get PS/2 working. It
would be easy to add new features - the battery monitoring - but as BaS
is also monitoring the PIC there might be conflicts when reading from
it. I'll have to look into how this is implemented, but my guess is that
this kind of stuff really should be handled by BaS alone.

But power off is safe the way the PIC works now. BaS only writes to the
PIC during power-up and power-down.

Jo Even