Re: [MiNT] [PATCH] Build fails

To: mint@lists.fishpool.fi
Subject: Re: [MiNT] [PATCH] Build fails
From: Vincent Rivière <vincent.riviere@freesbee.fr>
Date: Wed, 11 Dec 2013 17:57:49 +0100
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=03b9ZBzE8EZswhfgAJlfHvsICzk1rFRmiPvLLk9wh7Q=; b=GiKAQ2fgDq59++3doiUU082OQdyGKSv+8U5tn6cYH31kEBHDtl61ZYSwKF6i8es3ZA dKfiL4LvRWzu7FBds8Y+EZTtzJKxkfwu1VXiZ3DaGUzOzKjMPTiu9IQfnZA7MnHckN0/ FIKRgZccnrdbUBnVEoWhDmw7g0DC4tEM4Yqu3K/YPcTPcS0rVm2MN47WURP2FScEVoTZ RCpMyUbXMJWwJlCXleBAMMP494/uvqWUEf864eZ1hqqE4qYyayc8yNuF0AQPr1KwTJDk eVYeBfIG+3xhgd3CyxwKEQ1XYumjCnDTNzg0XaAty4I+Pu2T/bKJbr3vmw41uXaBy01q Jnhw==
In-reply-to: <CAN5rfbRShq2XeKPKNENcK4rkJOKrPuDhvVL0mZhG407j1b8Nfw@mail.gmail.com>
List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>
List-id: <mint.lists.fishpool.fi>
List-owner: <mailto:tjhukkan@fishpool.fi>
List-post: <mailto:mint@lists.fishpool.fi>
List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>
List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>
References: <CAN5rfbRShq2XeKPKNENcK4rkJOKrPuDhvVL0mZhG407j1b8Nfw@mail.gmail.com>
Sender: mint-bounce@lists.fishpool.fi
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20131118 Thunderbird/17.0.11

On 11/12/2013 17:46, Miro Kropáček wrote:

I'm attaching a trivial patch which fixes compilation on the latest
cross gcc.


I'm not sure what this code is about.

But if LAN_DATA is a hardware register, reading it (even if the value isnot used) might be very important.

So you should check twice before removing that code.

--
Vincent Rivière

Follow-Ups:
- Re: [MiNT] [PATCH] Build fails
  - From: Miro Kropáček <miro.kropacek@gmail.com>

References:
- [MiNT] [PATCH] Build fails
  - From: Miro Kropáček <miro.kropacek@gmail.com>