Re: [MiNT] [PATCH] Build fails

To: Alan Hourihane <alanh@fairlite.co.uk>

Subject: Re: [MiNT] [PATCH] Build fails

From: Miro Kropáček <miro.kropacek@gmail.com>

Date: Sun, 26 Jan 2014 20:55:16 +0100

Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mpR3S+qYU4ShSS2+XIMtaaCKrvTaMS796Ue+eMCTqn0=; b=Ws8Blogdcms2wP+aQGhHnOjg7GCIquTdfT7gy0WL7lTc6N/bMnwSrclGGj9iF3yoa8 hu+HB1wDJxyXVJsuVC47VVaHRAyFjZ6GzBubljJFHuf5FcuOhuPfiy0ZThB5GgB4MAwi IH2k0EULinqscBTnSxk/ajN6+14pVVEa1xFseFBfNhblGG/dD+mkTGjYdSUEZ51MJDcc GPFq436nbvy03APuIOsyEfZwm/c6/dAI+TYpJlLQW209gk22moEPpYI5Y2lJSN077kw1 tcRU821yENeHhOkAOu81hB4+muXeWklKYxFQTWPBPn9/DXJbWtmoARC8i+klSv1UX6Lp f0pw==

In-reply-to: <52AF12B4.8010503@fairlite.co.uk>

List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>

List-id: <mint.lists.fishpool.fi>

List-owner: <mailto:tjhukkan@fishpool.fi>

List-post: <mailto:mint@lists.fishpool.fi>

List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>

List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>

References: <CAN5rfbRShq2XeKPKNENcK4rkJOKrPuDhvVL0mZhG407j1b8Nfw@mail.gmail.com> <52A8998D.1050608@freesbee.fr> <CAN5rfbQ9vKptRKheTAT_z+-W+kp5u2dxcFNybA5UWRkgKpA46A@mail.gmail.com> <52A8A6C2.5070100@freesbee.fr> <CAN5rfbQ3dHqEBk_JbUQzU8tVwaOrbscsAz_8sb0Pp2XT-VR7xA@mail.gmail.com> <52ABAE70.9030900@fairlite.co.uk> <52AF0CF9.5020309@freesbee.fr> <52AF12B4.8010503@fairlite.co.uk>

Sender: mint-bounce@lists.fishpool.fi

OK, since my Ethernat refuses to work (fortunately we've got Svethlana now) I can't really verify this. But I still want to have a compilable source tree so here's another patch, disabling -Werror for 'ethernat' module until someone else comes with a smarter fix.

On Mon, Dec 16, 2013 at 3:48 PM, Alan Hourihane <alanh@fairlite.co.uk> wrote:

On 12/16/13 14:23, Vincent Rivière wrote:

On 14/12/2013 02:03, Alan Hourihane wrote:

Can you add "volatile" to the "long desttmp[2];" declaration for now ?

The classic way to silence "unused variable" warning is to use the UNUSED() macro somewhere in the function body.

But it's not unused. It's reading a hardware register, whereas volatile is the right choice.

Alan.

--
MiKRO / Mystic Bytes
http://mikro.atari.org

diff --git a/sys/sockets/xif/ethernat/Makefile b/sys/sockets/xif/ethernat/Makefile index 0fb3a53..2907eac 100644 --- a/sys/sockets/xif/ethernat/Makefile +++ b/sys/sockets/xif/ethernat/Makefile @@ -28,6 +28,7 @@ DEFINITIONS = -D__KERNEL_XDD__ $(XIF_DEFINITIONS) LD = $(CC) -mshort -nostdlib -Wl,--entry -Wl,_init LIBS = $(LIBKERN) -lgcc CPU = 060 +nocflags = -Werror # default definitions OBJS = $(addsuffix .o, $(basename $(notdir $(ETHERNAT_SRCS) $(COMMON_SRCS))))

Follow-Ups:

Re: [MiNT] [PATCH] Build fails
- From: "markus@mubf.de" <markus@mubf.de>