[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH] Remove attribute ((packed) from EHCI structs

To: "mint@lists.fishpool.fi" <mint@lists.fishpool.fi>
Subject: Re: [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs
From: David Gálvez <dgalvez75@gmail.com>
Date: Wed, 14 May 2014 18:24:50 +0200
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=LB8Yab48cRcZAs5qZ2/HusGEkwHGZVP48ZXjJwMRcZ4=; b=wknvOmkIRvpmrZSRJpVSkAEvQM8SXnGHt6PAqMo4bkHjWaD5STQ2rj3ZBKEeXDHHYH kIsoVEAaazpy5P1D1spZ6somHbbEZmiy4JBAxHUsju5waOYf0l8IymqyxM1RxCy/psUq 8vKqtplaEbHHfgSAPr0odBIEiPbNlvlNGUX7R1LcqyzFbEdqqjOIB2HtowGR7xNMR41y vbSVICG4THTouOvmNnmEfbjS76Xldh3Bc0uWGS0V55fBopsa9T7NYMkKo9Q3iGe9GvyH f+dMEKu0S/46dV0BJLbuUavKpAiJTFPBiAx5HgEVhC4InMflBDGiFJDP9/aN73NeNVpA /u6w==
In-reply-to: <53738F59.2070508@fairlite.co.uk>
List-help: <mailto:ecartis@lists.fishpool.fi?Subject=help>
List-id: <mint.lists.fishpool.fi>
List-owner: <mailto:tjhukkan@fishpool.fi>
List-post: <mailto:mint@lists.fishpool.fi>
List-subscribe: <mailto:mint-request@lists.fishpool.fi?Subject=subscribe>
List-unsubscribe: <mailto:mint-request@lists.fishpool.fi?Subject=unsubscribe>
References: <CAL4YKD4bFWNHJM5vGuMhsuCooZ8TLQhxYuPEEreC8quDUbDDtg@mail.gmail.com> <CAL4YKD4m-QD3m_tFK8MOr5T-4BCNWakvt8q5d_7AU4ubGMYtmw@mail.gmail.com> <53738F59.2070508@fairlite.co.uk>
Sender: mint-bounce@lists.fishpool.fi

2014-05-14 17:44 GMT+02:00 Alan Hourihane <alanh@fairlite.co.uk>:
> Ah yes, I forgot about it as I was going to post back. So I'll do this here.
>
> The reason I held off was that this is PCI code for EHCI controllers. And I
> know
> that we're building for 68000, but is there any hardware that exists for PCI
> on our 68000 machines ???
>
> I don't think so, so I'm inclined to leave "packed" in, as it's fine for
> 68020 and
> above, and we're really only talking CT60/Milan/Hades or FireBee at this
> point. Right ?
>

Yes, this was mentioned during the discussion about this issue. For me
is OK to leave the packet attribute, but I should change the makefile
to build for 020-60 for now.

References:
- [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs
  - From: David Gálvez <dgalvez75@gmail.com>
- Re: [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs
  - From: David Gálvez <dgalvez75@gmail.com>
- Re: [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs
  - From: Alan Hourihane <alanh@fairlite.co.uk>

Prev by Date: Re: [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs
Next by Date: [MiNT] [PATCH] Build ehci USB driver for 020-60
Previous by thread: Re: [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs
Next by thread: Re: [MiNT] MiNTlib timing related functions behavior/performance
Index(es):
- Date
- Thread

Re: [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs

Re: [MiNT] [PATCH] Remove attribute ((packed) from EHCI structs