Re: [MiNT] kern_ioctl() should return ENOSYS

[Helmut Karlowski <helmut.karlowski@ish.de>]

--------------------------------------------------
Thorsten Otto <halgara@yahoo.de> wrote:
(29/01/2015 17:46)

> 
> So sorry about complaining about cat ( i can only guess that the "official" version was also cross-compiled, using the original configure script, which falls back using a replaced stat() from the gnulib modules). But the behviour of the kernel calls is still wrong IMHO. If you look at other sources (like pipefs,c shmfs.c etc) you will also see that they all return ENOSYS in case of unhandled mode arguments. Its only kernfs.c that returns EINVAL.

Right.

In fatfs.c: fatfs_fscntl:

  FAT_DEBUG (("fatfs_fscntl: invalid function"));
  return ENOSYS;

in kernfs.c: kern_fscntl:

      DEBUG (("kern_fscntl: unknown opcode 0x%04x", (unsigned) cmd));
      return EINVAL;

Looks different ;) Guess kernfs.c should be changed.

-Helmut