[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH] Change name of kentry member XHNewCookie



Please, don't apply the patch yet I have problems to compile the
kernel after the changes.

2012/3/28 David Gálvez <dgalvez75@gmail.com>:
> Some time ago I added the function XHNewCookie to kentry struct to
> allow the installation of XHDI drivers.
> Now while rewriting part of the USB mass storage driver from assembly
> to C I see I must have chosen another name for the struct member.
> Drivers are going to use the names given by the XHDI specification and
> XHNewCookie will conflict with the function name in kentry.
> So to allow drivers to have their function names consistent I'd like
> to change the name in kentry.
> I think only USB mass storage driver has been using it so I think
> there will be no problem.
> I've been thinking in sending this patch or not because I find it a
> little bit ridiculous but I think is the thing to do.
>
> Comment:
>
> Change struct member name XHNewCookie to xhnewcookie to avoid possible
> conflicts with drivers code.