[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH] Remove __attribute__ ((packed) from EHCI structs

Ah yes, I forgot about it as I was going to post back. So I'll do this here.

The reason I held off was that this is PCI code for EHCI controllers. And I know
that we're building for 68000, but is there any hardware that exists for PCI
on our 68000 machines ???

I don't think so, so I'm inclined to leave "packed" in, as it's fine for 68020 and above, and we're really only talking CT60/Milan/Hades or FireBee at this point. Right ?


On 05/14/14 16:27, David Gálvez wrote:
Alan, this one is pending.

2014-05-02 12:57 GMT+02:00 David Gálvez <dgalvez75@gmail.com>:
Alan, one more. Thanks.

Commit message:

Remove __attribute__ ((packed) from ehci_hcor and ehci_hccr structs to
avoid slow generated code by gcc when compiled with -m68000 as pointed
by Vincent. Both structs don't change size when (packed) is removed.