[Freemint-list] [PATCH] TosWin2 fixes

Miro Kropáček miro.kropacek at gmail.com
Fri Jan 13 03:47:19 MSK 2017


>
> Even if your patch is quite short, you should not add new features in the
> same
> patch that is only supposed to fix a bug.

Well, I've fixed everything in one row but you're right, it's bad practice.


> Also i can't see anything that makes
> that new behaviour configurable. If you have some broken app that outputs
> to
> console, you will end up with with a toswin window thats pops up every
> time.
>
The new behaviour is actually just an extension. If you see an option "Open
at output", and the window doesn't open while the original author would say
to you it's meant only when iconified and now it's open in all cases, it
isn't something you'd like to configure, is it. ;) Same for logging, if you
specify "log it, please" and it doesn't work because the author didn't
implement it for all scenarios.

-- 
MiKRO / Mystic Bytes
http://mikro.atari.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.atariforge.org/pipermail/freemint-list/attachments/20170113/79b91306/attachment.html 


More information about the Freemint-list mailing list