[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [MiNT] an example of broken lib



Hi Julian!

> > Yep, sorry, this is insider knowledge: Could you change the type of the
> > first argument from "short int" to "long int"?  Otherwise, the library
> > binding actually had to check if the descriptor is out of bounds.  I think
> > this is better done by the kernel.
> 
> That would be inconsistent with the rest of the GEMDOS bindings (if by
> descriptor you mean "file handle").

Agreed.

> > A propos library binding: What if Ffchown() and Ffchmod() is not supported
> > by the kernel?  I would suggest to always return 0 for success in the
> > library.  For older MiNT versions this is somewhat problematic but it will
> > be handy for MagiC and TOS without mulit-user support.  Anybody has got
> > problems with that?
> >
> > The same applies under MiNT if the FS doesn't support these calls.  I
> > think it is ok to report success nonetheless, is it?
> 
> The kernel should pass back what the XFS reports. It shouldn't make any
> assumptions about why a particular error code is returned.

The kernel return an EINVFN as E_OK. I introduced this in 1.5.0 to make
the FAT filesystem more tar friendly. I see no negative side effect, it
exist Dpathconf() to verify if a feature is supported.


Tschuess
   ...Frank

--
ATARI FALCON 040 // MILAN 040
--------------------------------------
Internet: fnaumann@cs.uni-magdeburg.de
Mausnet:  Frank Naumann @ L2