[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH] Allow any UI language in the _AKP cookie



Vincent Rivière, 03.01.2013 23:05:21:

Hello.

I discovered that FreeMiNT only allowed _AKP languages from 0 to 5. Any
other language previously set in the initial _AKP cookie (from NVRAM)
was discarded and replaced by 0 (US).

Especially, this prevented XaAES t automatically load the correct
resources for the NVRAM language.

The attached patch fixes this issue. Please commit.

When there's nothing valid in NVRAM it uses the OS-lnaguage, and again only uses values up to 5 (and 7, 8). Is this ok?

Wouldn't this patch be better?

--- init_mach.c 2 Nov 2011 16:27:20 -0000       1.19.2.4
+++ init_mach.c 3 Jan 2013 22:59:04 -0000
@@ -257,19 +257,13 @@
                        case 7:         /* Swiss French */
                                gl_lang = 2;
                                break;
-                       case 4:         /* Spain */
-                               gl_lang = 4;
-                               break;
-                       case 5:         /* Italy */
-                               gl_lang = 5;
-                               break;
                        default:
-                               gl_lang = 0;
+                               gl_lang = i;
                                break;
                }
        }

-       if (gl_lang >= MAXLANG || gl_lang < 0)
+       if (gl_lang < 0)
                gl_lang = 0;

        return 0;


--
Helmut Karlowski