[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] Aw: Re: [PATCH] Make EHCI driver interrupt handler follow PCI-BIOS specification.

On 10/10/14 10:49, David Gálvez wrote:
> I have redone the patch.
>
> Could someone with more experience with inline assembly (Alan, Vincent
> or Markus) review again please? I'm concern with the asm keyword left
> inside the C function.
>
> Thanks
In _ehci_int_handle_asm: I'd probably do this....

    subq.l  #8,sp
    movem.l d1/a1,(sp)
    move.l  a0,-(sp)
    jsr     _ehci_interrupt_handle
    addq.l  #4,sp
    movem.l (sp),d1/a1
    addq.l  #8,sp
    rts

Then ehci_interrupt_handle can be declared like this...

long ehci_interrupt_handle(long param)
{
    struct ehci *ehci = (struct ehci *)param;

....

Then you can remove the asm volatile keyword entirely.

Alan.