[MiNT] Aw: Re: Re: [PATCH] Make EHCI driver interrupt handler follow PCI-BIOS specification.

["markus@mubf.de" <markus@mubf.de>]

> Gesendet: Freitag, 10. Oktober 2014 um 11:49 Uhr
> Von: "David Gálvez" <dgalvez75@gmail.com>
> An: "mint list" <mint@lists.fishpool.fi>
> Betreff: Re: [MiNT] Aw: Re: [PATCH] Make EHCI driver interrupt handler follow PCI-BIOS specification.
>
> I have redone the patch.
> 
> Could someone with more experience with inline assembly (Alan, Vincent
> or Markus) review again please? I'm concern with the asm keyword left
> inside the C function.
> 
> Thanks
> 

Hi David,

I have only looked at this line

+	/* PCI_BIOS specification: parameter is in a0 */
+	asm volatile("move.l	a0,%0\n\t" : "=g"(ehci) : : "a0","memory");

since it seems to be the only inline asm left in the patch. It looks fine for me now.

Cheers,
Markus