[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [MiNT] [PATCH][MiNTlib] Add ColdFire information to sysinfo
On 04/02/16 11:38, Andreas Schwab wrote:
> Alan Hourihane <alanh@fairlite.co.uk> writes:
>
>> On 04/02/16 11:19, Andreas Schwab wrote:
>>> Alan Hourihane <alanh@fairlite.co.uk> writes:
>>>
>>>> That 'case -1' doesn't look right. Shouldn't it be 'case 0xFFFF' ?
>>> 0xFFFF wouldn't match since hi is sign-extended.
>>>
>> I'd agree if there wasn't the & operation going on, but there is.
> It doesn't mask off the sign bit.
>
Right, actually it looks like it depends on the compiler and whether it
promotes the operation to 'unsigned'.
Alan.