[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] [PATCH][MiNTlib] Add ColdFire information to sysinfo



Alan Hourihane <alanh@fairlite.co.uk> writes:

> On 04/02/16 11:19, Andreas Schwab wrote:
>> Alan Hourihane <alanh@fairlite.co.uk> writes:
>>
>>> That 'case -1' doesn't look right. Shouldn't it be 'case 0xFFFF' ?
>> 0xFFFF wouldn't match since hi is sign-extended.
>>
>
> I'd agree if there wasn't the & operation going on, but there is.

It doesn't mask off the sign bit.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."