[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

release tty patch report (was: another 1.10 job control bug)



 Sorry Juergen, but your patch:

> Index: dosmem.c
> @@ -748,6 +749,7 @@
>		}
>	}
>
> +#if 0
>  /* release the controlling terminal, if we're a process group leader */
>	fp = curproc->handle[-1];
>	if (fp && is_terminal(fp) && curproc->pgrp == curproc->pid) {
> @@ -755,6 +757,26 @@
>		if (curproc->pgrp == tty->pgrp)
>			tty->pgrp = 0;
>	}
> +#else
> +/* release the controlling terminal, if we're the last member of this pgroup */
> +       fp = curproc->handle[-1];
> +       if (fp && is_terminal(fp)) {
> +               struct tty *tty = (struct tty *)fp->devinfo;
> +               int pgrp = curproc->pgrp;
>
> etc...

 regarding the release of the controlling terminal to re-enable more than
just one login on a tty doesn't work for me. On my machine, it's best to use
entropy's code with the '#if 1'. Nervously enough, I've never seen the
mentioned pipe problems. But then, as you know, my machine tends to behave
somehow weird sometimes... ;-)

ciao,
TeSche
--
Torsten Scherer (TeSche, Schiller...)
Faculty of Technology, University of Bielefeld, Germany, Europe, Earth,...
use any of "finger itschere@129.70.131.2-15" for infos or drop me a mail...