[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] Patch: shel_write() did not call the PureC patcher



On Wed, 2012-03-21 at 20:24 +0200, Eero Tamminen wrote:

> I would also suggest using something similar as what Linux kernel does
> to make code cleaner:
> ----header-----
> #ifdef COLDFIRE
> extern void   patch_memset_purec(BASEPAGE *b);
> #else
> #define patch_memset_purec(b)
> #endif
> ----c-files----
>     patch_memset_purec(b);
> ---------------
> 
> This way the ifdef stuff is localized to appropriate headers and
> C-files are clean.

In what way does this make the source cleaner? From what I can see the
only thing you accomplish with this is to hide the fact that this
function is only used on a Coldfire CPU.

Jo Even