[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] nf_ops struct in kentry

On Sun, 2010-11-21 at 14:04 +0100, Helmut Karlowski wrote:
> Am 20.11.2010, 13:41 Uhr, schrieb Alan Hourihane <alanh@fairlite.co.uk>:
> 
> > Thanks for doing that Helmut. Slipped through my net.
> 
> 
> Wouldn't it be better to write:
> 
> 
> -         kernelinfo.nf_ops = nf_init();
> -         kentry.vec_mch.nf_ops = nf_init();
> +         kentry.vec_mch.nf_ops = kernelinfo.nf_ops = nf_init();
> 
> instead? nf_init returns a pointer to a static struct.

Doesn't matter. It's not much saving here.

Alan.