[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MiNT] XaAES tempering with XBIOS resolution




2014-01-30 Miro Kropáček <miro.kropacek@gmail.com>:

On Thu, Jan 30, 2014 at 7:30 PM, Jo Even Skarstein <joska@online.no> wrote:
It should be, but it's explicitly stated that Vsetmode doesn't validate
the screenmode. Instead, I think that the screenmode should be validated
by the screenmode selector.

Actually, the mode is validated by the Vcheckmode() function in the same code block. But I don't know whether this functions checks this kind of discrepancies too or it's about VGA/RGB and double lines/interlace bits only.

Vcheckmode() is transforms RGB-resolutions into VGA-ditto, and filters out some invalid stuff - but not 80 col HC on VGA and 40 col mono. Even so, I think the correct approach would be to rely on this function and not make assumptions about modecodes.

-- PeP