[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Keyboard problems with MiNT 1.15.0 Beta 4 and Milan



> |> rather than:
> |> 
> |>                 /* xconin[] are always blocking, and we don't want to   
> |>                    hang at ipl7 even if something impossible like a     
> |>                    `magically' empty buffer happens.  so check again. */
> |>                 if (ior->tail != ior->head)
> |>                         if (buf)                                        
> |>                                 *p++ = callout1(*cin, bdev);            
> |>                         else                                            
> |>                                 (void) callout1(*cin, bdev);            
> 
> There is no semantic difference between theses two, it's just a matter of
> style.

Really? It seemed to me that the latter means:

                if (ior->tail != ior->head) {                  
                         if (buf)                             
                                 *p++ = callout1(*cin, bdev); 
                } else {                                 
                                 (void) callout1(*cin, bdev); 

		}

rather than:

                if (ior->tail != ior->head) {                 
                         if (buf) {                            
                                 *p++ = callout1(*cin, bdev); 
                	 } else {                                      
                                 (void) callout1(*cin, bdev);
			 }                                    
                }                                             

I.e. the "else" will be interpreted as opposite to "if (ior->tail !=
ior->head)" rather than to "if (buf)".

Sorry if I was wrong.

--			
Konrad M.Kokoszkiewicz
|mail: draco@mi.com.pl                  | Atari Falcon030/TT030/65XE |
|http://www.orient.uw.edu.pl/~conradus/ | ** FreeMiNT development ** |

** Ea natura multitudinis est,
** aut servit humiliter, aut superbe dominatur (Liv. XXIV,25)
*************************************************************
** U pospolstwa normalne jest, ze albo sluzy ono unizenie,
** albo bezczelnie sie panoszy.